Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payload for discussion_comment event #1781

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented Jan 18, 2024

Description

Long time no see :).

Add payload for discussion_comment event.
I already added discussion a while ago and someone in our team had a use case for discussion_comment.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Sorry, something went wrong.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa675f3) 80.41% compared to head (4932a7f) 80.44%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1781      +/-   ##
============================================
+ Coverage     80.41%   80.44%   +0.02%     
- Complexity     2309     2316       +7     
============================================
  Files           218      219       +1     
  Lines          7016     7026      +10     
  Branches        371      371              
============================================
+ Hits           5642     5652      +10     
  Misses         1141     1141              
  Partials        233      233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwiseman bitwiseman merged commit 5b30e46 into hub4j:main Jan 25, 2024
11 checks passed
@gsmet
Copy link
Contributor Author

gsmet commented Jan 25, 2024

Thanks @bitwiseman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants